Revert "FileConfigurationProvider.Dispose should dispose FileProvider when it owns it"#101609
Merged
adamsitnik merged 2 commits intomainfrom Apr 26, 2024
Merged
Revert "FileConfigurationProvider.Dispose should dispose FileProvider when it owns it"#101609adamsitnik merged 2 commits intomainfrom
adamsitnik merged 2 commits intomainfrom
Conversation
… when it…" This reverts commit 63fad3c.
Member
Author
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8850932380 |
4 tasks
adamsitnik
force-pushed
the
revert-86455-configLeak
branch
from
a7d5f93 to
18230fc
Compare
ericstj
approved these changes
Apr 26, 2024
Member
There was a problem hiding this comment.
Thank you for reverting this. I think it's the right call given we can't guarantee the right behavior for everyone.
We should make sure to reactivate #86146. I think the workaround mentioned in that issue is what we'd recommend folks use for now. Maybe we can work to update things like hosting/configuration to lead people to a use a single FileProvider and make sure its lifetime is managed.
Member
Author
I've reopened the issue, unlocked the conversation and set the Milestone to 9.0. |
This was referenced Apr 26, 2024
Closed
Closed
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
… when it owns it" (dotnet#101609) * Revert "FileConfigurationProvider.Dispose should dispose FileProvider when it…" This reverts commit 63fad3c. * Add test to ensure the bug does not come back
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
… when it owns it" (dotnet#101609) * Revert "FileConfigurationProvider.Dispose should dispose FileProvider when it…" This reverts commit 63fad3c. * Add test to ensure the bug does not come back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #86455 as it introduced a bug: #95745
fixes #95745