Skip to content

[LoongArch64] Add some R2R missing codes.#101480

Merged
jkotas merged 1 commit intodotnet:mainfrom
LuckyXu-HF:main-LA64-R2R
Apr 26, 2024
Merged

[LoongArch64] Add some R2R missing codes.#101480
jkotas merged 1 commit intodotnet:mainfrom
LuckyXu-HF:main-LA64-R2R

Conversation

@LuckyXu-HF
Copy link
Contributor

@LuckyXu-HF LuckyXu-HF commented Apr 24, 2024

[LoongArch64] Add some R2R missing codes for LA64.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 24, 2024
@am11 am11 added area-ReadyToRun-coreclr arch-loongarch64 and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 24, 2024
@am11
Copy link
Member

am11 commented Apr 24, 2024

Looks good! Please also add corresponding bits in src/tasks/Crossgen2Tasks/ResolveReadyToRunCompilers.cs. Once dotnet/installer#19469 is picked up (preview 4 update in global.json when it's released), we can enabled LA64 support in src/installer; similar to #96941.

This was referenced Apr 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 24, 2024
Closed
Closed
@LuckyXu-HF
Copy link
Contributor Author

LuckyXu-HF commented Apr 25, 2024 •
edited
Loading

Looks good! Please also add corresponding bits in src/tasks/Crossgen2Tasks/ResolveReadyToRunCompilers.cs. Once dotnet/installer#19469 is picked up (preview 4 update in global.json when it's released), we can enabled LA64 support in src/installer; similar to #96941.

Hi @am11 ，big thanks for your reminder, I have updated the corresponding bits in src/tasks/Crossgen2Tasks/ResolveReadyToRunCompilers.cs for LA64.

Note that the dll files generated by R2R in the main-dev branch temporarily is not as stable as our released 8.0 branch, may be some bugs still exists in main which we will continue to track.

@shushanhf Could you please review this PR? Thanks.

shushanhf
shushanhf approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

This was referenced Apr 25, 2024
Closed
Closed
Closed
Closed
@LuckyXu-HF
Copy link
Contributor Author

LuckyXu-HF commented Apr 25, 2024

Hi @jkotas , could you please review this PR? Thanks.

jkotas
jkotas approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@build-analysis build-analysis bot mentioned this pull request Apr 25, 2024
Closed
@jkotas
Copy link
Member

jkotas commented Apr 26, 2024

/ba-g Build analysis not recognizing known failure. See #101567 for details.

@jkotas jkotas merged commit a45853c into dotnet:main Apr 26, 2024
@LuckyXu-HF LuckyXu-HF deleted the main-LA64-R2R branch April 26, 2024 06:05
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@LuckyXu-HF @matouskozak
[LoongArch64] Add some R2R missing codes. (dotnet#101480)
632214e
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@LuckyXu-HF @michaelgsharp
[LoongArch64] Add some R2R missing codes. (dotnet#101480)
7215b35
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

+1 more reviewer

@shushanhf shushanhf shushanhf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-loongarch64 area-ReadyToRun-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LuckyXu-HF @am11 @jkotas @shushanhf

Comments