JIT: fix stress issue with profile consistency#101259
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Apr 18, 2024
Merged
JIT: fix stress issue with profile consistency#101259AndyAyersMS merged 1 commit intodotnet:mainfrom
AndyAyersMS merged 1 commit intodotnet:mainfrom
Conversation
In rare cases profile stress will put weight on unreachable preds of loop blocks, throwing off the cyclic probability computations. Fix by ignoring such preds.
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
@amanasifkhalid PTAL No diffs expected; will run stress. |
amanasifkhalid
approved these changes
Apr 18, 2024
Contributor
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
LGTM assuming stress modes pass -- thanks for seeing this through!
Member
Author
|
/azp run runtime-coreclr libraries-pgo, runtime-coreclr jitstress, runtime-coreclr pgostress, runtime-coreclr pgo |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Member
Author
|
/azp run runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
SPMI replay failure is #101070. |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
In rare cases profile stress will put weight on unreachable preds of loop blocks, throwing off the cyclic probability computations. Fix by ignoring such preds.
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rare cases profile stress will put weight on unreachable preds of loop blocks, throwing off the cyclic probability computations.
Fix by ignoring such preds.