Merged
Conversation
ghost
added
the
needs-area-label
MichalStrehovsky
added
area-Infrastructure
and removed
needs-area-label
This was referenced Apr 12, 2024
akoeplinger
approved these changes
Apr 15, 2024
akoeplinger
approved these changes
Apr 15, 2024
ViktorHofer
reviewed
Apr 15, 2024
Comment on lines
+14
to
+15
| <PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="9.0.0-preview.3.24172.13" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="9.0.0-preview.3.24172.13" PrivateAssets="all" /> |
Member
There was a problem hiding this comment.
Do we have an issue that tracks removing these hardcodes?
Member
Author
There was a problem hiding this comment.
Do we have an issue that tracks removing these hardcodes?
Might want to ask that @radekdoulik @maraf @pavelsavara who were involved in the PR that introduced it; looks like this has been causing extra work when bumping the SDK since 8.0 RC1.
ViktorHofer
approved these changes
Apr 15, 2024
MichalStrehovsky
added
the
NO-MERGE
Member
Author
|
Looks like the new run is hitting a hard crash in the runtime on osx-x64. I doubt it was caused by the latest commit, so this is one of those fun non-deterministic crashes in MSBuild: I guess this is now NO-MERGE/blocked. Filed #101049. |
3 tasks
Member
|
Doesn't seem related given we found more hits in older releases in #101049 so I triggered a rerun. |
Member
|
All green after the rerun. |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Update global.json * Update blazor.csproj * Delete useless `RuntimeIdentifiers` * Fix up illinker tests * Fix two more preview1 versions --------- Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.