Unify debug views of immutable dictionaries#100745
Merged
eiriktsarpalis merged 3 commits intodotnet:mainfrom Jul 5, 2024
Merged
Unify debug views of immutable dictionaries#100745eiriktsarpalis merged 3 commits intodotnet:mainfrom
eiriktsarpalis merged 3 commits intodotnet:mainfrom
Conversation
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
huoyaoyuan
reviewed
Apr 7, 2024
src/libraries/System.Private.CoreLib/src/System/Collections/Generic/IDictionaryDebugView.cs
Show resolved
Hide resolved
This was referenced Apr 15, 2024
Fixes dotnet#94289 - Updates the way the debugger displays the remaining dictionaries (Frozen, Immutable, ImmutableSorted, Concurrent) to present their keys and values in separate columns. - Fixes debugger views of Builder classes of immutable collections. Previous custom implementations incorrectly treated the Builder classes as immutable.
…ric dictionaries * Removed tests superseded by DebugView.Tests. * Fixed DebugView.Tests of cuncurrent and immutable generic dictionaries which failed on .Net Framework
eiriktsarpalis
force-pushed
the
ImmutableDictionaryDebuggerTypeProxy
branch
from
d722940 to
a3aa221
Compare
This was referenced Jun 24, 2024
This was referenced Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94289