fix building error for error: fallthrough annotation in unreachable code#100742
Merged
AaronRobinsonMSFT merged 1 commit intodotnet:mainfrom Apr 9, 2024
Merged
fix building error for error: fallthrough annotation in unreachable code#100742AaronRobinsonMSFT merged 1 commit intodotnet:mainfrom
error: fallthrough annotation in unreachable code#100742AaronRobinsonMSFT merged 1 commit intodotnet:mainfrom
Conversation
Contributor
shushanhf
commented
Apr 7, 2024
Contributor
Author
|
Hi, @jkotas I find @AaronRobinsonMSFT @jkoritzinsky by https://github.com/dotnet/runtime/blob/main/docs/area-owners.md |
Member
|
Is this on a |
Member
|
The problem here, and something the above code now doesn't handle, is this code is calling into a user defined |
Contributor
Author
On Debug build on the LoongArch64-linux with clang-13 and arm64 linux with clang-8. |
cfea3aa to
59b798c
Compare
3 tasks
jkotas
reviewed
Apr 8, 2024
bb7dcec to
2a1cc85
Compare
…code` when building on debug mode on loongarch64/arm64/amd64-linux by clang<14. Also delete `#ifndef FALLTHROUGH` block as dotnet#98336 added after dotnet#98712.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…code` (dotnet#100742) when building on debug mode on loongarch64/arm64/amd64-linux by clang<14. Also delete `#ifndef FALLTHROUGH` block as dotnet#98336 added after dotnet#98712.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.