Arm64/Sve: Implement ConditionalSelect API#100718
Arm64/Sve: Implement ConditionalSelect API#100718kunalspathak wants to merge 4 commits intodotnet:mainfrom
Conversation
kunalspathak
commented
Apr 6, 2024
kunalspathak
commented
ghost
added
|
Note regarding the |
|
@dotnet/arm64-contrib |
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
| @@ -0,0 +1,362 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
|
|
|||
There was a problem hiding this comment.
Is this template based on an existing template?
Can we just use a generic 3 op template here? I don't think I see anthing specific to conditionalselect
|
|
||
| /// ConditionalSelect : Conditionally select elements | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
byte(Byte),double(Double),short(Int16),int(Int32),long(Int64),nint(IntPtr),sbyte(SByte),float(Single),ushort(UInt16),uint(UInt32),ulong(UInt64), nuint (UIntPtr)
There was a problem hiding this comment.
@a74nh - do you mind fixing the tool to generate these alphabetically?
There was a problem hiding this comment.
@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.
| public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; } | ||
| public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; } | ||
|
|
||
| public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; } |
There was a problem hiding this comment.
If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.
kunalspathak
added
arm-sve
|
Replaced with #100743 |
3 participants
