Add Channel.CreateUnboundedPrioritized#100550
Merged
adamsitnik merged 1 commit intodotnet:mainfrom Apr 15, 2024
Merged
Conversation
|
Note regarding the |
adamsitnik
approved these changes
Apr 15, 2024
Member
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @stephentoub
I've found some minor nits, but since you are OOF and this PR needs to be merged for P4 I am going to merge it right away.
src/libraries/System.Threading.Channels/src/System/Threading/Channels/Channel.netcoreapp.cs
Show resolved
Hide resolved
| Assert.Equal(21, p.Age); | ||
| Assert.Equal(1, c.Reader.Count); | ||
|
|
||
| Assert.True(c.Reader.TryRead(out p)); |
Member
There was a problem hiding this comment.
nit: this logic could be moved to a helper method to avoid copying the code
private static void ReadNext(Channel<Person> c, int expectedAge, int expectedCount)
{
Assert.True(c.Reader.TryRead(out p));
Assert.Equal(expectedAge, p.Age);
Assert.Equal(expectedCount, c.Reader.Count);
}
Member
Author
|
Thanks, @adamsitnik. |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62761