Commit Accounting related changes#100380
Merged
cshung merged 7 commits intodotnet:mainfrom May 22, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/gc |
9beeb42 to
34c53c5
Compare
cc4c736 to
fcbcdc2
Compare
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 7, 2024
Maoni0
reviewed
May 8, 2024
Maoni0
reviewed
May 8, 2024
4d24a44 to
78d6849
Compare
78d6849 to
1a3ef3c
Compare
Maoni0
reviewed
May 21, 2024
Maoni0
approved these changes
May 21, 2024
Member
Maoni0
left a comment
There was a problem hiding this comment.
other than the one small comment, LGTM!
Contributor
Author
|
This change is tested with all these combinations: x86/x64 Bug #102585 is found, but it is unrelated to commit accounting. |
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heap_segmentare moved across heaps duringchange_heap_count, this change records them so thatcommitted_by_oh_per_heapis still valid.committed_byvalues regardless ofheap_hard_limit, which will allow usrefresh_memory_limitfor segments.verify_regionsinto_DEBUG.release_segment, heap_segment are released byvirtual_free, we need to also decrement the committed counters when that happen.get_segment, we accidentally usedmax_generationasohfor UOH segments, this change will make it use the rightoh.grow_brick_card_table, heap_segment are released byvirtual_free, we need to also decrement the committed counters when that happen.... to be continued.