Fix HalfNumberBufferLength#100187
Merged
tannergooding merged 2 commits intodotnet:mainfrom Mar 25, 2024
Merged
Conversation
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Member
|
I don’t have a preference for where the test is added. You can link to the associated GitHub issue regardless |
tannergooding
approved these changes
Mar 25, 2024
Member
Author
|
@tannergooding Does this require backport for 8.0? |
Member
|
We've not gotten any custom reports on this and it currently throws an exception if the user tries. Particularly since it only impacts subnormals, I'd guess we want to wait to see if anyone else hits this. CC. @jeffhandley |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98841
I'm not sure where to add test. Should I create a single regression test, or add a case to Half.ToString tests?