JIT: Set bbCodeOffsEnd to BAD_IL_OFFSET when expanding static init calls#100152
Merged
TIHan merged 2 commits intodotnet:mainfrom Mar 25, 2024
Merged
JIT: Set bbCodeOffsEnd to BAD_IL_OFFSET when expanding static init calls#100152TIHan merged 2 commits intodotnet:mainfrom
bbCodeOffsEnd to BAD_IL_OFFSET when expanding static init calls#100152TIHan merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Member
|
The tests in NativeAOT are disable with a comment pointing to |
Contributor
Author
|
@filipnavara thanks, I didn't realize that. I'll re-enable them. |
Contributor
Author
|
/azp run runtime-nativeaot-outerloop |
AndyAyersMS
approved these changes
Mar 22, 2024
Contributor
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will resolve #100125
The IL offsets in expanding static init is really tricky as a lot happens here, even in Debug compilations. Such as, user statements can actually be modified, as well as user blocks.
Since this is only limited to expanding static init calls, the quickest and easiest solution is to simply set the block's ending offset to BAD_IL_OFFSET.