Update CodeAnalysis config to include recently-added rules#100146
Merged
stephentoub merged 1 commit intodotnet:mainfrom Mar 25, 2024
Merged
Update CodeAnalysis config to include recently-added rules#100146stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
stephentoub
requested review from
MichalStrehovsky and
marek-safar
as code owners
ghost
added
the
needs-area-label
buyaa-n
reviewed
Mar 22, 2024
buyaa-n
reviewed
Mar 22, 2024
buyaa-n
reviewed
Mar 22, 2024
buyaa-n
added
area-Meta
and removed
needs-area-label
This was referenced Mar 22, 2024
stephentoub
force-pushed
the
updateanalysis
branch
from
604ac5e to
4276a45
Compare
stephentoub
force-pushed
the
updateanalysis
branch
2 times, most recently
from
acb4d11 to
e9f454c
Compare
stephentoub
force-pushed
the
updateanalysis
branch
from
e9f454c to
1b5d61c
Compare
stephentoub
force-pushed
the
updateanalysis
branch
from
1b5d61c to
6c8ac2b
Compare
This was referenced Mar 25, 2024
Member
|
This made WASM startup faster, thanks @stephentoub :) |
Member
Author
Interesting. That's a nice side effect, though it wasn't the primary intent :) Do you know why it got faster? Only explanation I could think of were some of the string-to-char changes could have resulted possibly in globalization code not being needed until later? |
Member
|
There was a search for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.