add boolean parsing variations#2234
Merged
danmoseley merged 4 commits intodotnet:mainfrom Feb 6, 2022
Merged
Conversation
Member
Author
|
@DrewScoggins @LoopedBard3 |
Member
|
Looks like the ClientRS4 queue is EOL and the likely upgrade is to ClientRS5. I will do a test run to see if using the new queue fixes the issue. |
Member
|
Testing in PR #2237, will update once the run completes. |
Member
|
Closing for rebase since #2237 has been merged. |
Member
|
It appears reopening did not catch the latest queue update. |
Member
Author
|
performance-ci (windows RS4 x64 micro_net461 Open LTS) results can be ignored. it's a dead queue |
Member
Author
|
@LoopedBard3 perhaps you'd like to review so I can merge? |
stephentoub
reviewed
Feb 5, 2022
stephentoub
reviewed
Feb 5, 2022
Member
Author
|
Now
|
stephentoub
reviewed
Feb 5, 2022
stephentoub
approved these changes
Feb 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I get on my machine, without dotnet/runtime#64782