Adds Microsoft.Extensions.* performance tests with history#1362
Adds Microsoft.Extensions.* performance tests with history#1362adamsitnik merged 33 commits intodotnet:masterfrom
Conversation
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter. Commit migrated from dotnet/extensions@7ce647c
Commit migrated from dotnet/extensions@18fcffb
Commit migrated from dotnet/extensions@34204b6
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96 Commit migrated from dotnet/extensions@689c4a8
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee Commit migrated from dotnet/extensions@04e957b
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185 Commit migrated from dotnet/extensions@9a4c61b
Commit migrated from dotnet/extensions@5b8b6c7
Commit migrated from dotnet/extensions@3ba072c
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d Commit migrated from dotnet/extensions@f3cd14a
Commit migrated from dotnet/extensions@f162f10
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7 Commit migrated from dotnet/extensions@c38f9c1
Commit migrated from dotnet/extensions@888bcba
Commit migrated from dotnet/extensions@63cde57
This includes the master branch of aspnet/HttpClientFactory Commit migrated from dotnet/extensions@557995e
Use arcade Commit migrated from dotnet/extensions@f045899
* Remove obsolete targets, properties, and scripts * Replace IsProductComponent with IsShipping * Undo bad merge to version.props * Update documentation, and put workarounds into a common file * Replace usages of RepositoryRoot with RepoRoot * Remove API baselines * Remove unnecessary restore feeds and split workarounds into two files * Enable PR checks on all branches, and disable autocancel Commit migrated from dotnet/extensions@f41cfde
Commit migrated from dotnet/extensions@2f8e1fb
Commit migrated from dotnet/extensions@8f0f7fa
Commit migrated from dotnet/extensions@20ce03a
* Support netcoreapp3.1 TFM * Unpin SDK for source build * Update to preview1 branding Commit migrated from dotnet/extensions@32cc816
Commit migrated from dotnet/extensions@321a30c
...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Show resolved
Hide resolved
- Needed to later get InternalsVisibleTo on DI
adamsitnik
left a comment
There was a problem hiding this comment.
@maryamariyan big thanks for porting all these benchmarks to the performance repo!
the porting itself looks very good, however, I have some comments related to the benchmarks themselves. Before we merge them we should make sure that they follow our guidelines
As soon as all suggestions are applied, I am going to merge this PR.
Once again big thanks for all the work @maryamariyan ! It took me a few hours to review it, I can imagine how long it took to actually port them!
...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated
Show resolved
Hide resolved
...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated
Show resolved
Hide resolved
...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated
Show resolved
Hide resolved
...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/Microsoft.Extensions.Http/LoggingOverheadBenchmark.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/Microsoft.Extensions.Http/CreationOverheadBenchmark.cs
Outdated
Show resolved
Hide resolved
Make batch commit using suggestions in PR feedback Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
|
@adamsitnik ready for re-review. |
06463d4 to
4caa9bd
Compare
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM! Thank you @maryamariyan !
...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated
Show resolved
Hide resolved
...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated
Show resolved
Hide resolved
|
One of the CI legs failed with a really strange error: I am going to re-run it. Edit: I can see exactly same error in #1372 so it's not related to this PR |
Related convo: #1360 (comment)
cc: @JunTaoLuo @adamsitnik @halter73 @davidfowl