Merged
Conversation
Context: fb94d59 fb94d59 added code to collect all overriden method descriptors in a list, so that the future marshal methods code generator can generate correct code for them. However, not all gathered descriptors contained name of the managed type which declares the overridden methods. This commit fixes the problem.
jonpryor
reviewed
May 19, 2022
| Connector = parts[2]; | ||
| if (parts.Length > 3) { | ||
| ManagedTypeName = parts[3]; | ||
| ManagedTypeName = parts[3].Replace ('/', '+'); |
Contributor
There was a problem hiding this comment.
Given that the reason for this isn't particularly clear, I think it would be helpful if we had a "nicely named method" "somewhere".
Question is what the method should be named, and where it should go.
Spending 2 seconds on it, I'd suggest putting it with TypeDefinitionRocks:
partial class TypeDefinitionRocks {
public static string CecilTypeNameToReflectionTypeName (string typeName) => typeName.Replace ('/', '+');
}Yes, it's longer, but at least it makes it clear why we're doing this.
Should probably update TypeDefinitionRocks' use of .Replace('/', '+') as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: fb94d59
fb94d59 added code to collect all overriden method descriptors in
a list, so that the future marshal methods code generator can generate
correct code for them. However, not all gathered descriptors contained
name of the managed type which declares the overridden methods. This
commit fixes the problem.