[Java.Intreop] Rename Dispose methods#238
Merged
jonpryor merged 1 commit intodotnet:masterfrom Jan 3, 2018
Merged
Conversation
Contributor
|
As mentioned on our last call, if we're going to rename
Thus, a question: which is "better", |
b188f6e to
b8bd979
Compare
Member
Author
|
Indeed, I misremembered it as belonging to another fix. Updated. |
Contributor
|
We should also rename |
These have different signatures than the common dispose pattern methods, thus rename them to avoid confusion. Also rename other methods working with IJavaPeerable to be consistent. Catched by gendarme's https://github.com/spouliot/gendarme/wiki/Gendarme.Rules.Design.UseCorrectDisposeSignaturesRule(2.10)
b8bd979 to
10a18ef
Compare
Member
Author
|
Updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These have different signatures than the common dispose pattern
methods, thus rename them to avoid confusion.
Catched by gendarme's
https://github.com/spouliot/gendarme/wiki/Gendarme.Rules.Design.UseCorrectDisposeSignaturesRule(2.10)