[class-parse] Fix Java parameter loader for generics involved methods.#215
Merged
jonpryor merged 1 commit intodotnet:masterfrom Nov 16, 2017
Merged
Conversation
When there is a method that takes one or more parameters that are generic instances whose type definition contains more than one type parameters (e.g. `java.util.Map<K,V>`), they resulted in java.util.Map<X,Y> whereas API XML contains java.util.Map<X, Y> (notice the extra space between generic arguments) and method type matching failed. We should not change parameter definitions format (it is clearly declared to NOT contain spaces within generic arguments), so expand that at loader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a method that takes one or more parameters that are generic
instances whose type definition contains more than one type parameters
(e.g.
java.util.Map<K,V>), they resulted in java.util.Map<X,Y> whereasAPI XML contains java.util.Map<X, Y> (notice the extra space between generic
arguments) and method type matching failed.
We should not change parameter definitions format (it is clearly declared
to NOT contain spaces within generic arguments), so expand that at loader.