[java-source-utils] Ignore CodeQL SM00697 java/path-injection-local#1222
Merged
jonpryor merged 1 commit intodotnet:mainfrom May 23, 2024
Merged
Conversation
Fixes: https://codeql.microsoft.com/issues/5011e9f8-1b9e-4735-b9c5-89d78d9c04b2 Fixes: https://codeql.microsoft.com/issues/a9013ebf-d97c-41d8-aa62-92da7f8ea1c7 Fixes: https://codeql.microsoft.com/issues/b42d4728-2ce4-4599-b5cb-4d2affb86985 Fixes: https://codeql.microsoft.com/issues/bafce9a0-95ae-4aac-95e0-5ba8af1f3944 Fixes: https://codeql.microsoft.com/issues/bcc73986-161f-40b4-96a4-1c7e52959941 Fixes: https://codeql.microsoft.com/issues/dd199e97-a989-4f18-9fc7-a23a497eba32 Fixes: https://codeql.microsoft.com/issues/e844028d-77d8-4e04-9bfd-24005727ea84 Context: 5fa7ac4 Context: https://codeql.microsoft.com/issues/repository?Uri=https%3A%2F%2Fgithub.com%2Fxamarin%2Fjava.interop# Context: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/codeql/codeql-semmle#guidance-on-suppressions Commit 5fa7ac4 "addressed" numerous LGTM warnings around "path injection". We're now using CodeQL, and even though CodeQL *started as* LGTM, it (apparently) no longer supports the previous `// lgtm` comments. It instead wants `// CodeQL` comments, updated to use an "Opaque Id". Update the comments to silence the CodeQL warnings.
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
May 28, 2024
Changes: dotnet/java-interop@78d5937...f935001 * dotnet/java-interop@f935001d: Force loc task pool image to windows (dotnet/java-interop#1223) * dotnet/java-interop@d8d9b4c7: Bump to xamarin/xamarin-android-tools/main@137ad81 (dotnet/java-interop#1221) * dotnet/java-interop@729c8064: [java-source-utils] Ignore CodeQL SM00697 java/path-injection-local (dotnet/java-interop#1222) * dotnet/java-interop@d6dfe4ab: [ci] Update OneLocBuildToken (dotnet/java-interop#1220) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://codeql.microsoft.com/issues/5011e9f8-1b9e-4735-b9c5-89d78d9c04b2
Fixes: https://codeql.microsoft.com/issues/a9013ebf-d97c-41d8-aa62-92da7f8ea1c7
Fixes: https://codeql.microsoft.com/issues/b42d4728-2ce4-4599-b5cb-4d2affb86985
Fixes: https://codeql.microsoft.com/issues/bafce9a0-95ae-4aac-95e0-5ba8af1f3944
Fixes: https://codeql.microsoft.com/issues/bcc73986-161f-40b4-96a4-1c7e52959941
Fixes: https://codeql.microsoft.com/issues/dd199e97-a989-4f18-9fc7-a23a497eba32
Fixes: https://codeql.microsoft.com/issues/e844028d-77d8-4e04-9bfd-24005727ea84
Context: 5fa7ac4
Context: https://codeql.microsoft.com/issues/repository?Uri=https%3A%2F%2Fgithub.com%2Fxamarin%2Fjava.interop#
Context: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/codeql/codeql-semmle#guidance-on-suppressions
Commit 5fa7ac4 "addressed" numerous LGTM warnings around "path injection".
We're now using CodeQL, and even though CodeQL started as LGTM, it (apparently) no longer supports the previous
// lgtmcomments. It instead wants// CodeQLcomments, updated to use an "Opaque Id".Update the comments to silence the CodeQL warnings.