Add UnixFilePermissions.xml to Emscripten pkgs#31
Merged
directhex merged 2 commits intodotnet:mainfrom Jun 21, 2021
Merged
Conversation
added 2 commits
June 21, 2021 13:05
…ot executable by the end user: ``` -rwxr--r-- 1 root wheel 106K May 31 07:30 /usr/local/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.2.0.12.Sdk.osx-x64/6.0.0-preview.5.21281.1/tools/bin/llc ``` Ref: dotnet/runtime#54501 Ref: dotnet/runtime#53545 Ref: dotnet/sdk#16894 Ref: dotnet/macios#11869 Ref: dotnet/android#6010
Member
|
should have read it more cosely |
Member
|
We should probably auto-generate this list somehow, otherwise it's going to get stale with emscripten version bumps... |
Member
|
yeah, since getting the list wrong will break workload install we need to either autogenerate it or check it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As is, emsdk files installed to a system location via workloads are not executable by the end user:
Ref: dotnet/runtime#54501
Ref: dotnet/runtime#53545
Ref: dotnet/sdk#16894
Ref: dotnet/macios#11869
Ref: dotnet/android#6010