Skip to content

adding missing RIDs#886

Merged
mairaw merged 5 commits intomasterfrom
rid
Aug 25, 2016
Merged

adding missing RIDs#886
mairaw merged 5 commits intomasterfrom
rid

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Aug 8, 2016

Fixes #829, #923

Pending questions:

  • Windows AOT RIDs: these are for .NET Native. Should I add them to the docs?

/cc @richlander @blackdwarf

* `linuxmint.18-x64`

## OS X RIDs
## Mac RIDs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say "macOS" per #612 (comment)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think @richlander? Should we keep OS X as you suggested back in that earlier comment? I was following how we're calling the OSes on this page for this change: https://www.microsoft.com/net/core

@mairaw
Copy link
Contributor Author

mairaw commented Aug 22, 2016

Updated the doc based on comments from @piotrpMSFT and @ericstj. Thanks guys!

There's still a question on whether we want to list the AOT RIDs at this point or not, but this is ready for review if we don't.

/cc @blackdwarf

@mairaw mairaw removed the WIP label Aug 22, 2016
@dend dend closed this Aug 22, 2016
@dend dend reopened this Aug 22, 2016
@blackdwarf
Copy link

@ericstj are AOT RIDs targetable?

@ericstj
Copy link
Member

ericstj commented Aug 24, 2016

What do you mean by targetable? No RIDs are "targetable" today because NuGet doesn't allow for different compile time assemblies based on RID (what we typically refer to when we say targetable). RIDs control what runtime assemblies are used. We do indeed use the aot RIDs for UWP applications when that application is using the .NETNative toolchain.

@mairaw
Copy link
Contributor Author

mairaw commented Aug 24, 2016

@ericstj so I should add them here to this doc too? Can people use that in their json files already in their .NET Core projects?

@ericstj
Copy link
Member

ericstj commented Aug 24, 2016

Not for .NET Core, only UWP.

@blackdwarf
Copy link

@ericstj I meant are they "usable" for a, for instance, self-contained deployment, to which you gave an answer above. OK, so since these are .NET Core docs, I would suggest not putting them in and keeping with those we can use in .NET Core projects.

@mairaw
Copy link
Contributor Author

mairaw commented Aug 24, 2016

Yes, I agree with this plan @blackdwarf. And what about the changes? Do they look OK to you?

@blackdwarf
Copy link

:shipit:

@mairaw mairaw merged commit 682b27c into master Aug 25, 2016
@mairaw mairaw deleted the rid branch August 30, 2016 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants