This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Fixing two conditions that also need to trigger when TestWithLocalNativeLibraries is true#1008
Merged
joperezr merged 1 commit intodotnet:masterfrom Sep 2, 2016
Merged
Conversation
…iveLibraries is true
Member
Author
|
Merging now since we need this for corefx. I'll address any feedback in a follow-up PR. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is needed for dotnet/corefx#11366 since when we moved to use TestWithLocalNativeLibraries property we actually broke using the native shims, which now is causing non-Windows CI builds to fail for dev/api.
cc: @ericstj