Fix CodeAnalysis analyzerdata includes#4996
Merged
ViktorHofer merged 2 commits intomasterfrom Mar 6, 2020
Merged
Conversation
This was referenced Mar 6, 2020
Member
|
What is the actual fix here? It's hard to see what's meaningful vs all of the formatting changes. |
Replace the usage of TargetGroup which was corefx specific with TargetFramework and TargetFrameworkIdentifier. Those are default SDK properties so everyone should be able to use that package. This was broken recently by the removal of the TargetGroup property in dotnet/runtime.
ViktorHofer
force-pushed
the
ViktorHofer-codeanalysis
branch
from
bc64f8b to
9bc4159
Compare
Member
Author
|
Sorry for the inconvenience. I was in the middle of fixing the commits when you commented. Please take another look. Commit 2 is the bugfix. |
stephentoub
reviewed
Mar 6, 2020
|
|
||
| <!-- Disable any analyzers that should not run --> | ||
| <DisabledAnalyzers Condition="'$(IsTestProject)' == 'true' or '$(TargetsUnix)' == 'true' or '$(EnablePInvokeAnalyzer)' != 'true'" Include="PInvokeAnalyzer"/> | ||
| <DisabledAnalyzers Condition="'$(TargetsWindows)' == 'true' and ($(TargetGroup.Contains('net46')) or $(TargetGroup.Contains('net45')))" Include="PInvokeAnalyzer" /> |
Member
There was a problem hiding this comment.
Have we searched the rest of arcade for places that might still be erroneously using TargetGroup?
Member
Author
There was a problem hiding this comment.
I assumed @Anipik did that when he removed the property. We have one more hit (
) which is unproblematic as it falls back to TargetFramework. We should clean that up in a subsequent PR. Not going to touch this PR as it's currently blocking my work in runtime.
Anipik
approved these changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally format code.
cc @stephentoub