[release/8.0.2xx] [tests] fix InvalidTargetPlatformVersion for net8.0#9110
Merged
jonathanpeppers merged 3 commits intorelease/8.0.2xxfrom Jul 16, 2024
Merged
Conversation
When 60dbcc9 was backported to .NET 8, the accompanying unit test was accidentally targeting .NET 9.
dellis1972
approved these changes
Jul 15, 2024
dellis1972
approved these changes
Jul 15, 2024
Member
Author
|
I don't see Rolf's changes from dotnet/sdk@25b360d in this file: This causes the So, let me see if this starts working from a newer .NET SDK. |
Member
Author
|
Ok, I don't see that change in .NET 8 at all: So, I guess we just remove part of this test. |
pjcollins
approved these changes
Jul 15, 2024
Member
Author
|
There are some random/flaky failures for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When 60dbcc9 was backported to .NET 8, the accompanying unit test was accidentally targeting .NET 9.