[Xamarin.Android.Build.Tasks] Allow override of uncompressedGlob.#7965
[Xamarin.Android.Build.Tasks] Allow override of uncompressedGlob.#7965jonpryor merged 3 commits intodotnet:mainfrom
uncompressedGlob.#7965Conversation
jonathanpeppers
left a comment
There was a problem hiding this comment.
LGTM, but a lot of CI failed due to a random policy thing.
We'll probably have to rerun when that is fixed.
956eee1 to
9bb07c9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Context: https://www.newtonsoft.com/json/help/html/P_Newtonsoft_Json_Linq_JsonMergeSettings_MergeArrayHandling.htm The What the docs don't say is what those necessarily mean.
I don't know what this means. For example, what happens if we merge
Is |
558ef09 to
ae46538
Compare
|
@dellis1972: please rebase this PR; the unit test failures are "weird", and I don't see how this PR could cause them. |
ae46538 to
3798408
Compare
I'm not sure what this means either. I suspect it means by |
3798408 to
e754668
Compare
fbae410 to
a0b0c3a
Compare
0d80bce to
8b55352
Compare
89f8f83 to
7751a7d
Compare
7751a7d to
dabbe5a
Compare
Users reported that when they added a custom `uncompressedGlob` entry to the `$(AndroidBundleConfigurationFile)`, it was ignored. This is because the `MergeArrayHandling` option we were using in the `BuildAppBundle` task was set to `MergeArrayHandling.Replace`. As a result we would just overwrite the user config with our own. We should be using the `MergeArrayHandling.Union` option instead. This with merge the arrays , but will remove duplicates. This should allow users to provide additional `uncompressedGlob` options. A unit test has been added to test this new behaviour.
dabbe5a to
598db23
Compare
* main: [Xamarin.Android.Build.Tasks] Allow override of `uncompressedGlob` (dotnet#7965)
Users reported that when they added a custom
uncompressedGlobentry to the$(AndroidBundleConfigurationFile), it was ignored. This is because theMergeArrayHandlingoption we were using in theBuildAppBundletask was set toMergeArrayHandling.Replace.As a result we would just overwrite the user config with our own. We should be using the
MergeArrayHandling.Unionoption instead. This with merge the arrays , but will remove duplicates. This should allow users to provide additionaluncompressedGloboptions.A unit test has been added to test this new behaviour.