Skip to content

Comments

[tests] Bump NUnit versions to latest#7802

Merged
jonpryor merged 1 commit intomainfrom
jpobst-patch-1
Feb 17, 2023
Merged

[tests] Bump NUnit versions to latest#7802
jonpryor merged 1 commit intomainfrom
jpobst-patch-1

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Feb 16, 2023 •
edited
Loading

The tests on the run MSBuildDeviceIntegration On Device - macOS-1 - One .NET job are not running due to this error:

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Exception NUnit.VisualStudio.TestAdapter.NUnitEngine.DiscoveryException,    Exception thrown executing tests in /Users/runner/work/1/s/xamarin-android/bin/TestRelease/MSBuildDeviceIntegration/net7.0/MSBuildDeviceIntegration.dll
Not a TestFixture, SetUpFixture or TestSuite, but ParameterizedFixture
   at NUnit.VisualStudio.TestAdapter.NUnitEngine.DiscoveryConverter.ExtractTestFixtures(NUnitDiscoveryCanHaveTestFixture parent, XElement node) in D:\repos\NUnit\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\DiscoveryConverter.cs:line 272
   at NUnit.VisualStudio.TestAdapter.NUnitEngine.DiscoveryConverter.ExtractAllFixtures(NUnitDiscoveryTestSuite parent, XElement node) in D:\repos\NUnit\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\DiscoveryConverter.cs:line 223
   at NUnit.VisualStudio.TestAdapter.NUnitEngine.DiscoveryConverter.ExtractAllFixtures(NUnitDiscoveryTestSuite parent, XElement node) in D:\repos\NUnit\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\DiscoveryConverter.cs:line 229
   at NUnit.VisualStudio.TestAdapter.NUnitEngine.DiscoveryConverter.ExtractAllFixtures(NUnitDiscoveryTestSuite parent, XElement node) in D:\repos\NUnit\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\DiscoveryConverter.cs:line 229
   at NUnit.VisualStudio.TestAdapter.NUnitEngine.DiscoveryConverter.ExtractAllFixtures(NUnitDiscoveryTestSuite parent, XElement node) in D:\repos\NUnit\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\DiscoveryConverter.cs:line 229
   at NUnit.VisualStudio.TestAdapter.NUnitEngine.DiscoveryConverter.ConvertXml(NUnitResults discovery) in D:\repos\NUnit\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\DiscoveryConverter.cs:line 179
   at NUnit.VisualStudio.TestAdapter.NUnitEngine.DiscoveryConverter.Convert(NUnitResults discoveryResults, String assemblyPath) in D:\repos\NUnit\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\DiscoveryConverter.cs:line 134
   at NUnit.VisualStudio.TestAdapter.NUnit3TestExecutor.RunAssembly(String assemblyPath, IGrouping`2 testCases, TestFilter filter) in D:\repos\NUnit\nunit3-vs-adapter\src\NUnitTestAdapter\NUnit3TestExecutor.cs:line 279
No test matches the given testcase filter `TestCategory = Node-1 & TestCategory != TimeZoneInfo & TestCategory != Localization & TestCategory != DotNetIgnore & TestCategory != HybridAOT & TestCategory != MkBundle & TestCategory != MonoSymbolicate & TestCategory != PackagesConfig & TestCategory != S...` in /Users/runner/work/1/s/xamarin-android/bin/TestRelease/MSBuildDeviceIntegration/net7.0/MSBuildDeviceIntegration.dll
Results File: /Users/runner/work/1/s/xamarin-android/TestResult-MSBuildDeviceIntegration-mac_dotnetdevice_tests_1-Release.xml

Source: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7343148&view=logs&j=ef53a832-6b9d-50db-0090-851acbb6bf0a&t=fba7f8c5-5b66-5210-3a07-28605b5a156a

This is fixed in NUnit3TestAdapter version 4.1:
nunit/nunit3-vs-adapter#867 (reply in thread)

Update NUnit to latest versions to fix, which results in:

Passed!  - Failed:     0, Passed:    60, Skipped:     0, Total:    60, Duration: 52 m 32 s - MSBuildDeviceIntegration.dll (net7.0)
Finishing: run MSBuildDeviceIntegration On Device - macOS-1 - One .NET

@dotnet dotnet deleted a comment from azure-pipelines bot Feb 16, 2023
@jpobst jpobst marked this pull request as ready for review February 17, 2023 00:36
@jpobst jpobst requested a review from jonpryor as a code owner February 17, 2023 00:36
@jonpryor jonpryor merged commit 3a2e629 into main Feb 17, 2023
@jonpryor jonpryor deleted the jpobst-patch-1 branch February 17, 2023 17:08
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 17, 2023
@grendello
Merge branch 'main' into no-ndk-lib-stubs
2b53bd8 
* main:
  [tests] Bump NUnit versions to latest (dotnet#7802)
  [Microsoft.Android.Sdk.ILLink] target `net7.0` temporarily (dotnet#7803)
  [tests] `InstallAndroidDependenciesTest` can use `platform-tools` 34.0.0 (dotnet#7800)
  Bump to xamarin/Java.Interop/main@9e0a469 (dotnet#7797)
  [Xamarin.Android.Build.Tasks] FileWrites&libraryprojectimports.cache (dotnet#7780)
  Bump to dotnet/installer@d25a3bb 8.0.100-preview.2.23105.6 (dotnet#7769)
  [lgtm] Fix LGTM-reported issues (dotnet#1074)
  [ci] Report issues in the API docs build log (dotnet#7784)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 20, 2023
@grendello
Merge branch 'main' into native-code-classic-cleanup
cc5e44f 
* main:
  [tests] Bump NUnit versions to latest (dotnet#7802)
  [Microsoft.Android.Sdk.ILLink] target `net7.0` temporarily (dotnet#7803)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 20, 2023
@grendello
Merge branch 'main' into classloader-thread-init
c124f55 
* main:
  [tests] Bump NUnit versions to latest (dotnet#7802)
  [Microsoft.Android.Sdk.ILLink] target `net7.0` temporarily (dotnet#7803)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 22, 2023
@grendello
Merge branch 'main' into http-compression-fix
876c32e 
* main:
  [tests] Bump NUnit versions to latest (dotnet#7802)
  [Microsoft.Android.Sdk.ILLink] target `net7.0` temporarily (dotnet#7803)
  [tests] `InstallAndroidDependenciesTest` can use `platform-tools` 34.0.0 (dotnet#7800)
  Bump to xamarin/Java.Interop/main@9e0a469 (dotnet#7797)
  [Xamarin.Android.Build.Tasks] FileWrites&libraryprojectimports.cache (dotnet#7780)
  Bump to dotnet/installer@d25a3bb 8.0.100-preview.2.23105.6 (dotnet#7769)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 22, 2023
@grendello
Merge branch 'main' into no-bundleassemblies
8032a0d 
* main:
  Add Unit Test for testOnly apps (dotnet#7637)
  [build] Only build the latest API level (dotnet#7786)
  [Xamarin.Android.Build.Tasks] Improve aapt2+file not found handling (dotnet#7644)
  [MSBuildDeviceIntegration] Fix duplicated test parameter (dotnet#7809)
  [tests] Bump NUnit versions to latest (dotnet#7802)
  [Microsoft.Android.Sdk.ILLink] target `net7.0` temporarily (dotnet#7803)
  [tests] `InstallAndroidDependenciesTest` can use `platform-tools` 34.0.0 (dotnet#7800)
  Bump to xamarin/Java.Interop/main@9e0a469 (dotnet#7797)
  [Xamarin.Android.Build.Tasks] FileWrites&libraryprojectimports.cache (dotnet#7780)
  Bump to dotnet/installer@d25a3bb 8.0.100-preview.2.23105.6 (dotnet#7769)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 22, 2023
@grendello
Merge branch 'main' into maybe-fix-zip
02b022b 
* main:
  Add Unit Test for testOnly apps (dotnet#7637)
  [build] Only build the latest API level (dotnet#7786)
  [Xamarin.Android.Build.Tasks] Improve aapt2+file not found handling (dotnet#7644)
  [MSBuildDeviceIntegration] Fix duplicated test parameter (dotnet#7809)
  [tests] Bump NUnit versions to latest (dotnet#7802)
  [Microsoft.Android.Sdk.ILLink] target `net7.0` temporarily (dotnet#7803)
  [tests] `InstallAndroidDependenciesTest` can use `platform-tools` 34.0.0 (dotnet#7800)
  Bump to xamarin/Java.Interop/main@9e0a469 (dotnet#7797)
  [Xamarin.Android.Build.Tasks] FileWrites&libraryprojectimports.cache (dotnet#7780)
  Bump to dotnet/installer@d25a3bb 8.0.100-preview.2.23105.6 (dotnet#7769)
  [lgtm] Fix LGTM-reported issues (dotnet#1074)
  [ci] Report issues in the API docs build log (dotnet#7784)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpobst @jonpryor