Revert "Workaround FirstChanceExceptionEventArgs being trimmed"#7118
Revert "Workaround FirstChanceExceptionEventArgs being trimmed"#7118
Conversation
|
@jonpryor ping |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@akoeplinger: sorry for the delay. Do you have a link handy to the dotnet/runtime commit which contains the fix? |
|
@jonpryor dotnet/runtime#68235 for main and dotnet/runtime#68265 for the 6.0 backport |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
left a comment
There was a problem hiding this comment.
LGTM, I reran two tests that had some failures.
b74530b to
3f01aca
Compare
|
Windows build stopped building. Rebased on main, force-pushed. |
|
This is good for .NET 7/main. Just FYI, we should be wary backporting this to .NET 6 -- maybe we don't even need to. We'll need to make sure the dotnet/runtime schedule matches up with ours, if we do backport. |
|
Yeah backporting to .NET6 isn't really needed at this point I think since the workaround works and the only impact is the FirstChanceExceptionEventArgs type being preserved unconditionally rather than only when it's used. |
Reverts #6953
The fix for this issue is backported to dotnet/runtime 6.0 now so we can revert the workaround.