[API-31 enumification] Fix some new enums created in wrong namespaces.#6177
Merged
[API-31 enumification] Fix some new enums created in wrong namespaces.#6177
Conversation
Contributor
[API-31 enumification] Fix some enum namespaces names (#6177)
Context: 88438081c6db1e38547ed5afea9aa701329ac01c
We enumified API-31 constants in commit 88438081. However, some of
the namespaces used for these enums did not reflect the changes we
apply with `metadata` for capitalization or plurality purposes.
A later "verify any new namespaces added" check on @jpobst 's machine
revealed these changes. (TODO: Export that tool off his machine.)
For example, the following namespaces were renamed:
* `Android.App.Appsearch` to `Android.App.AppSearch`.
* `Android.Location` to `Android.Locations`. |
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 25, 2021
Context: 8843808 We enumified API-31 constants in commit 8843808. However, some of the namespaces used for these enums did not reflect the changes we apply with `metadata` for capitalization or plurality purposes. A later "verify any new namespaces added" check on @jpobst 's machine revealed these changes. (TODO: Export that tool off his machine.) For example, the following namespaces were renamed: * `Android.App.Appsearch` to `Android.App.AppSearch`. * `Android.Location` to `Android.Locations`.
jonpryor
pushed a commit
that referenced
this pull request
Aug 26, 2021
Context: 8843808 We enumified API-31 constants in commit 8843808. However, some of the namespaces used for these enums did not reflect the changes we apply with `metadata` for capitalization or plurality purposes. A later "verify any new namespaces added" check on @jpobst 's machine revealed these changes. (TODO: Export that tool off his machine.) For example, the following namespaces were renamed: * `Android.App.Appsearch` to `Android.App.AppSearch`. * `Android.Location` to `Android.Locations`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #6089
In #6089 we added enumifications for API-31 constants. However some of the namespaces used for these enums did not reflect the changes we apply with
metadatato capitalization or plurality. A later "verify any new namespaces added" check revealed these changes.Example: