Feature/connect options notify#460
Conversation
|
|
mikolak
left a comment
mikolak
left a comment
There was a problem hiding this comment.
There's one more issue to solve in the PR to MultiplatformBleAdapter, but afterwards we can go ahead and start merging! Thanks for both pull requests, tremendous work!
lib/peripheral.dart
Outdated
| refreshGatt: refreshGatt, | ||
| timeout: timeout); | ||
| timeout: timeout, | ||
| isNotifyOnConnection: isNotifyOnNotification, |
There was a problem hiding this comment.
| isNotifyOnConnection: isNotifyOnNotification, | |
| isNotifyOnConnection: isNotifyOnConnection, |
lib/peripheral.dart
Outdated
| bool isNotifyOnConnection = false, | ||
| bool isNotifyOnDisconnection = false, | ||
| bool isNotifyOnNotification = false}) => |
There was a problem hiding this comment.
Could you add dart docs for the new arguments?
example/ios/Flutter/.last_build_id
Outdated
| @@ -0,0 +1 @@ | |||
| 0c043f712767a79a690d42e9fd9f6d89 No newline at end of file | |||
There was a problem hiding this comment.
This file should be ignored, I think?
example/ios/Podfile
Outdated
| end | ||
|
|
||
| # Keep pod path relative so it can be checked into Podfile.lock. | ||
| pod 'MultiplatformBleAdapter', :git => 'https://github.com/devVadimAlbul/MultiPlatformBleAdapter.git', :branch => 'feature/connect-options' |
There was a problem hiding this comment.
This will have to be reverted before merging - marking to not forget
|
@devVadimAlbul is this PR still alive? |
As this is a new feature that does not introduce any breaking changes, it can go in any major release and I'd rather not postpone the release too much. I'm only one man with one or two evenings a week maximum. |
4 participants
Please you need to add this changed code to your branch for the possibility to set options to the device to notify the app when device connection/disconnect in background mode.
It works with changes in the library
MultiPlatformBleAdapter