Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5010 +/- ##
=======================================
Coverage 61.48% 61.48%
=======================================
Files 298 298
Lines 20814 20814
=======================================
Hits 12797 12797
Misses 7105 7105
Partials 912 912 |
3 tasks
thaJeztah
reviewed
Apr 12, 2024
81ae886 to
c220581
Compare
c220581 to
719f88e
Compare
719f88e to
eca29b5
Compare
eca29b5 to
218fbf8
Compare
thaJeztah
approved these changes
Jul 3, 2024
Comment on lines
+91
to
+178
| You can specify options like `-a=[]` multiple times in a single command line, | ||
| for example in these commands: | ||
|
|
||
| ```console | ||
| $ docker run -a stdin -a stdout -i -t ubuntu /bin/bash | ||
|
|
||
| $ docker run -a stdin -a stdout -a stderr ubuntu /bin/ls |
Member
There was a problem hiding this comment.
Not for this PR, but we need to look at some of these; -a / --attach is shown as list, and those can take multiple values, but for other flags, Cobra is good at silently ignoring duplicates, and in that case overriding previous values. (e.g. -i -i=false -i=true -i)
Also for a follow-up, we should pick a different example than -a, as it's really more of an "expert" use-case to set that. Perhaps something like -e / --env or something common could be a good one to pick as example (the --env one can be nice as we could show the result;
$ docker run --rm -e ENV_ONE=one -e ENV_TWO=two alpine printenv
ENV_ONE=one
ENV_TWO=two
<...>
```.Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
218fbf8 to
dc22572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Moves the
cli.mdfile to become thedocker.mdbase command reference.This file contains a lot of information about how the CLI and its flags work, base flags, configuration file, and environment variables. I think it makes more sense to have it on the base command page than in a separate place.
Needs:
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)