e2e: update notary certificates#4123
Merged
thaJeztah merged 3 commits intodocker:masterfrom Mar 27, 2023
Merged
Conversation
thaJeztah
added
status/2-code-review
process/cherry-pick
area/testing
kind/bugfix
thaJeztah
approved these changes
Mar 27, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
oh! fancy 😄
LGTM (if CI is happy)
Member
|
If we need this for 20.10, we probably need to modify it a bit when backporting, but that's for a later concern (worst case, we just copy over the certs to that branch) |
Member
Author
|
I can just have an extra commit with just the certs to ease backport if you want? edit: done (see last commit) |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
e2e-fix-certs
branch
from
d679651 to
b201ce5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4123 +/- ##
=======================================
Coverage 59.16% 59.16%
=======================================
Files 287 287
Lines 24716 24716
=======================================
Hits 14623 14623
Misses 9209 9209
Partials 884 884 |
Member
|
Whoop! All green; thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #4122 (comment)
- What I did
Update notary certificates for e2e tests and increase tests certificates duration to 10 years (3 years previously).
Also moves script to generate certificates to a dedicated Dockerfile to be sandboxed:
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)