Conversation
Dockerfile
Outdated
| FROM --platform=$BUILDPLATFORM tonistiigi/xx@sha256:21a61be4744f6531cb5f33b0e6f40ede41fa3a1b8c82d5946178f80cc84bfc04 AS xx | ||
|
|
||
| FROM --platform=$BUILDPLATFORM golang:1.16-alpine AS golatest | ||
| FROM --platform=$BUILDPLATFORM golang:1.17-alpine AS golatest |
There was a problem hiding this comment.
Should we have a test-matrices to test current and n-1 versions of go?
also see docker/cli#3258 (comment)
There was a problem hiding this comment.
Should we have a test-matrices to test
currentandn-1versions of go?
Good idea I will add a dedicated matrix in a follow-up.
also see docker/cli#3258 (comment)
Ah yes buildx is rebuilt through the packaging pipeline. Forgot that.
There was a problem hiding this comment.
I'm not sure we need a matrix. This is a cli tool. Good pattern to leave them configurable though.
go.mod
Outdated
| golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2 // indirect | ||
| golang.org/x/net v0.0.0-20210226172049-e18ecbb05110 // indirect | ||
| golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d // indirect | ||
| golang.org/x/sys v0.0.0-20210426230700-d19ff857e887 // indirect |
There was a problem hiding this comment.
Go 1.17 on macOS requires golang/sys@a76c4d0 (May 8) or later
|
A extra topic, could we remove the whole the newer version of golang we use, the go modules is more stable. |
No, I'm against that. Dependencies should tracked as other source code for reviews, edits, debugging etc. |
|
@tonistiigi PTAL, I'll leave at 1.16 in go.mod for now to avoid golang/go#46144 in other projects. |
5 participants
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com