fix exit code when manifest merge failed#2424
Merged
tonistiigi merged 1 commit intodocker:masterfrom Apr 24, 2024
Merged
Conversation
889882e to
e0a76d3
Compare
Signed-off-by: jaihwan104 <42341126+jaihwan104@users.noreply.github.com>
e0a76d3 to
f282351
Compare
tonistiigi
approved these changes
Apr 22, 2024
Contributor
Author
|
@tonistiigi Thank you for the review. I'd like to apply the official version to the production. Could you please add it to milestone v0.14.1? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the immutable policy is applied to tags and the manifest push fails, the exit code is calculated as 0. This issue occurs when using the remote driver.
We are building images in GitLab CI. Even though the image was not pushed properly, the exitCode is calculated as 0, so the job is not stopping properly.
fix exit code when manifest merge failed as follow:
before:
after: