util/imagetools: remove unused Resolver.ImageConfig#1950
Merged
jedevc merged 1 commit intodocker:masterfrom Jul 17, 2023
Merged
util/imagetools: remove unused Resolver.ImageConfig#1950jedevc merged 1 commit intodocker:masterfrom
jedevc merged 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
remove_imageutil_dead_code
branch
from
b2c9482 to
b9e25e8
Compare
Member
Author
|
oh, nice; that also removes ttrpc as dependency 😄 |
This was referenced Jul 17, 2023
crazy-max
approved these changes
Jul 17, 2023
Member
Author
|
@jedevc good to go? |
jedevc
approved these changes
Jul 17, 2023
crazy-max
reviewed
Jul 17, 2023
| github.com/cenkalti/backoff/v4 v4.2.0 // indirect | ||
| github.com/cespare/xxhash/v2 v2.2.0 // indirect | ||
| github.com/cloudflare/cfssl v0.0.0-20181213083726-b94e044bb51e // indirect | ||
| github.com/containerd/ttrpc v1.2.2 // indirect |
Member
There was a problem hiding this comment.
Now sure why it does remove ttrpc 🤔
Member
There was a problem hiding this comment.
Oh github.com/moby/buildkit/util/imageutil has a depedency on it nevermind.
Member
Author
There was a problem hiding this comment.
Yup! Turtles all the way down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.