test: register docker worker with containerd snapshotter#1897
Merged
crazy-max merged 4 commits intodocker:masterfrom Jun 20, 2023
Merged
test: register docker worker with containerd snapshotter#1897crazy-max merged 4 commits intodocker:masterfrom
crazy-max merged 4 commits intodocker:masterfrom
Conversation
crazy-max
commented
Jun 20, 2023
| cmd := buildxCmd( | ||
| sb, | ||
| withArgs("build", "-q", outFlag, "--iidfile", filepath.Join(targetDir, "iid.txt"), "--metadata-file", filepath.Join(targetDir, "md.json"), dir), | ||
| withArgs("build", "-q", "--provenance", "false", outFlag, "--iidfile", filepath.Join(targetDir, "iid.txt"), "--metadata-file", filepath.Join(targetDir, "md.json"), dir), |
Member
Author
There was a problem hiding this comment.
@tonistiigi Needs to disable provenance for this test with containerd storage as it would export an OCI image:
{
"containerimage.buildinfo": {
"frontend": "dockerfile.v0",
"attrs": {
"filename": "Dockerfile"
},
"sources": [
{
"type": "docker-image",
"ref": "docker.io/library/busybox:latest",
"pin": "sha256:0d5a701f0ca53f38723108687add000e1922f812d4187dea7feaee85d2f5a6c5"
}
]
},
"containerimage.descriptor": {
"mediaType": "application/vnd.oci.image.index.v1+json",
"digest": "sha256:ce51e4ac359feabf7a34388bb599e84873ba9299ce8b863ead9a093a16ffc875",
"size": 855
},
"containerimage.digest": "sha256:ce51e4ac359feabf7a34388bb599e84873ba9299ce8b863ead9a093a16ffc875",
"image.name": "moby-dangling@sha256:ce51e4ac359feabf7a34388bb599e84873ba9299ce8b863ead9a093a16ffc875"
}This is a test case we can add in follow-up. I guess we need to read "containerimage.descriptor".annotations."config.digest".
jedevc
reviewed
Jun 20, 2023
jedevc
reviewed
Jun 20, 2023
59ff674 to
90c0bff
Compare
Member
Author
|
Hum no tests run with |
90c0bff to
4778fbf
Compare
jedevc
approved these changes
Jun 20, 2023
4778fbf to
1f308af
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
1f308af to
155eb3a
Compare
Member
Author
So it's fine with |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
155eb3a to
28a1eb3
Compare
tonistiigi
reviewed
Jul 6, 2023
| ARG TARGETPLATFORM | ||
| ARG DOCKER_VERSION | ||
| WORKDIR /opt/docker | ||
| RUN DOCKER_ARCH=$(case ${TARGETPLATFORM:-linux/amd64} in \ |
Member
There was a problem hiding this comment.
Can't you do this with xx-info march ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #1886 (comment)
Adds
docker+containerdworker to our matrix to be able to test against dockerd with containerd storage enabled.