Skip to content

story/HOP-28#24

Open
Girik1105 wants to merge 11 commits intodevelopfrom
story/HOP-28
Open

story/HOP-28#24
Girik1105 wants to merge 11 commits intodevelopfrom
story/HOP-28

Conversation

@Girik1105
Copy link
Contributor

@Girik1105 Girik1105 commented Mar 10, 2026

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

It needs to be possible to configure the workflow id of the LLM backend

Description

As long as we’re using SIM as backend, it needs to be easier to change the URL. All SIM urls have the same format, with the workflow id being the only thing that changes. In the Django Admin, it should be possible to curate multiple workflows. For now, selecting just one to be used. So lets create a new model SimWorkflow with title, description, workflow id.
Only Django admins should be able to change the workflows.

Anything else the reviewer needs to know?

Does this Pull request depend on any other?

@diging-jenkins
Copy link

Can one of the admins verify this patch?



def _get_endpoint():
from ask.models import SimWorkflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason this would not be part of the general import statements?


def _get_endpoint():
from ask.models import SimWorkflow
active = SimWorkflow.get_active()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we want the active workflow of type "agent"

# action to select exactly one workflow and activate it
# the model's save() will auto-deactivate all others
@admin.action(description="Set selected workflow as active")
def set_as_active(self, request, queryset):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there can be multiple active workflows, just not multiple active workflows of the same type. so there can be an active workflow of type agent, one of type "update documents", etc. (even though we have only one type at the moment)

@jdamerow jdamerow closed this Mar 11, 2026
@Girik1105 Girik1105 reopened this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants