Open
Conversation
…ed constraints on admin simworkflow based on active workflow, help text in admin:
|
Can one of the admins verify this patch? |
jdamerow
requested changes
Mar 11, 2026
hospexplorer/ask/llm_connector.py
Outdated
|
|
||
|
|
||
| def _get_endpoint(): | ||
| from ask.models import SimWorkflow |
Member
There was a problem hiding this comment.
is there a reason this would not be part of the general import statements?
hospexplorer/ask/llm_connector.py
Outdated
|
|
||
| def _get_endpoint(): | ||
| from ask.models import SimWorkflow | ||
| active = SimWorkflow.get_active() |
Member
There was a problem hiding this comment.
here we want the active workflow of type "agent"
| # action to select exactly one workflow and activate it | ||
| # the model's save() will auto-deactivate all others | ||
| @admin.action(description="Set selected workflow as active") | ||
| def set_as_active(self, request, queryset): |
Member
There was a problem hiding this comment.
there can be multiple active workflows, just not multiple active workflows of the same type. so there can be an active workflow of type agent, one of type "update documents", etc. (even though we have only one type at the moment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
It needs to be possible to configure the workflow id of the LLM backend
Description
As long as we’re using SIM as backend, it needs to be easier to change the URL. All SIM urls have the same format, with the workflow id being the only thing that changes. In the Django Admin, it should be possible to curate multiple workflows. For now, selecting just one to be used. So lets create a new model SimWorkflow with title, description, workflow id.
Only Django admins should be able to change the workflows.
Anything else the reviewer needs to know?
Does this Pull request depend on any other?