Configure automatic spelling check via codespell within pre-commit#121
Merged
sbillinge merged 5 commits intodiffpy:mainfrom Oct 29, 2024
bobleesj:spelling
Merged
Configure automatic spelling check via codespell within pre-commit#121sbillinge merged 5 commits intodiffpy:mainfrom bobleesj:spelling
sbillinge merged 5 commits intodiffpy:mainfrom
bobleesj:spelling
Conversation
bobleesj
commented
Oct 29, 2024
|
|
||
| * Updated REAMDE instructions for pip and conda-forge install | ||
| * Updated REAMDE instructions to check for successful installation | ||
| * Updated README instructions for pip and conda-forge install |
Contributor
Author
There was a problem hiding this comment.
typo found by codespell
bobleesj
commented
Oct 29, 2024
| Improvements and fixes are always appreciated. | ||
|
|
||
| Before contribuing, please read our `Code of Conduct <https://github.com/diffpy/diffpy.snmf/blob/main/CODE_OF_CONDUCT.rst>`_. | ||
| Before contributing, please read our `Code of Conduct <https://github.com/diffpy/diffpy.snmf/blob/main/CODE_OF_CONDUCT.rst>`_. |
Contributor
Author
There was a problem hiding this comment.
typo found by codespell
bobleesj
commented
Oct 29, 2024
| .. _quick_start: | ||
|
|
||
| Tutorial (To be addded) | ||
| Tutorial (To be added) |
Contributor
Author
There was a problem hiding this comment.
typo found by codespell
bobleesj
commented
Oct 29, 2024
| =========== | ||
|
|
||
| Please enjoy using our software! If you come accross any bugs in the | ||
| Please enjoy using our software! If you come across any bugs in the |
Contributor
Author
There was a problem hiding this comment.
typo found by codespell
bobleesj
commented
Oct 29, 2024
| [tool.codespell] | ||
| exclude-file = ".codespell/ignore_lines.txt" | ||
| ignore-words = ".codespell/ignore_words.txt" | ||
| skip = "*.cif" |
bobleesj
commented
Oct 29, 2024
| where K is the number of component signals and M is the number of XRD/PDF patterns. | ||
|
|
||
| component_matrix: 2d array lik | ||
| component_matrix: 2d array like |
Contributor
Author
There was a problem hiding this comment.
typo found by codespell
bobleesj
commented
Oct 29, 2024
Contributor
Author
bobleesj
left a comment
bobleesj
left a comment
There was a problem hiding this comment.
Ready for review! @sbillinge This is great.
Contributor
Author
|
I think the CI fails for 3.13, as expected. But please merge since it will be resolved once we have diffpy.utils 3.13 on feedstock.. soon |
Contributor
|
This is fantastic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will add to the cookiecutter repo after further finding common terms to ignore in diffpy.srmise and diffpy.utils
Ref: scikit-package/scikit-package#168