Support 3.12 CI - conda install wxPython, pip install gooey - to prevent building wxPython#137
Support 3.12 CI - conda install wxPython, pip install gooey - to prevent building wxPython#137sbillinge merged 4 commits intodiffpy:mainfrom bobleesj:gooey-ci-build
wxPython, pip install gooey - to prevent building wxPython#137Conversation
|
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
|
(Not ready for review) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 6 6
Lines 293 293
=======================================
Hits 291 291
Misses 2 2 |
.github/workflows/tests-on-pr.yml
Outdated
| shell: bash -l {0} | ||
|
|
||
| runs-on: ubuntu-latest | ||
| runs-on: macos-latest |
There was a problem hiding this comment.
It turns out wxpython needs to be built for linux since no native whl is provided while we have windows/macos whl files provided shown below:
Since @yucongalicechen and I test using macOS, what if we setup a MacOS CI instead?
There was a problem hiding this comment.
Move back to Linux after we add wxpython to conda.txt
| diffpy.utils | ||
| pandas | ||
| scipy | ||
| gooey |
There was a problem hiding this comment.
Removed gooey from conda.txt since we won't be able to install it and it will only fail the CI during conda install.
There was a problem hiding this comment.
I think we need to add wxpython to conda.txt
|
@sbillinge ready for review. pls see in-line comments. Thank you. |
|
@yucongalicechen tagging Yucong as well to share what's going on here. |
bobleesj
changed the title
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
Does adding wxpython to conda.txt allow you to set it back to Linux-latest?
I checked wxpython's conda-forge files, no support for py313 as of now: 
So it will most likely break the CI while installing it. |
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
It might be cleaner to close this and redo following the regolith protocol
| diffpy.utils | ||
| pandas | ||
| scipy | ||
| gooey |
There was a problem hiding this comment.
I think we need to add wxpython to conda.txt
.github/workflows/tests-on-pr.yml
Outdated
| shell: bash -l {0} | ||
|
|
||
| runs-on: ubuntu-latest | ||
| runs-on: macos-latest |
There was a problem hiding this comment.
Move back to Linux after we add wxpython to conda.txt
| conda config --set always_yes yes | ||
| --set changeps1 no | ||
|
|
||
| - name: Install libgtk for Linux |
There was a problem hiding this comment.
libgtk is no longer needed. here, wxpython is install via conda-forge as suggested.
bobleesj
changed the title
bobleesj
changed the title
wxPython, pip install gooey - to prevent building wxPython
|
@sbillinge ready for review - thanks for the suggestion. wxpython is conda-installed as suggested while gooey is pip installed. |
|
nice. Much cleaner. |
2 participants
No description provided.