remove wavelength from loading metadata#123
Merged
sbillinge merged 3 commits intodiffpy:mainfrom Nov 1, 2024
Merged
Conversation
sbillinge
approved these changes
Nov 1, 2024
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
This is good. But I think it is non-intuitive that it would be this way, so I would add a comment on the METADATA_KEYS_TO_EXCLUDE that mentions that we exclude wavelength because of (why). this will help avoid confusion in the future likely
Collaborator
Author
|
@sbillinge ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #121
Output before removal:
Output after removal:
@sbillinge ready for review