Skip to content

Resolves issue #38#53

Merged
devvsakib merged 1 commit intodevvsakib:masterfrom
Tanyaverma3114:master
Oct 28, 2022
Merged

Resolves issue #38#53
devvsakib merged 1 commit intodevvsakib:masterfrom
Tanyaverma3114:master

Conversation

@Tanyaverma3114
Copy link
Copy Markdown
Contributor

@Tanyaverma3114 Tanyaverma3114 commented Oct 27, 2022

Added a jewelry blog website.
@devvsakib please review and merge the pull request.

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
frontend-projects ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 9:47PM (UTC)

@devvsakib
Copy link
Copy Markdown
Owner

devvsakib commented Oct 28, 2022

why you closed pull request? @Tanyaverma3114

@Tanyaverma3114
Copy link
Copy Markdown
Contributor Author

Tanyaverma3114 commented Oct 28, 2022

1 check got failed, so, I didn't want to spam with unnecessary PR. I'm really sorry. I tried uploading another project but the same check failed.

@devvsakib
Copy link
Copy Markdown
Owner

devvsakib commented Oct 28, 2022

1 check got failed, so, I didn't want to spam with unnecessary PR. I'm really sorry. I tried uploading another project but the same check failed.

this error doesnt matter. its just check code.

@Tanyaverma3114
Copy link
Copy Markdown
Contributor Author

Tanyaverma3114 commented Oct 28, 2022

Oh ohhkk...I didn't know about that as I'm new to it😅.
I'm reopening this PR. Can you please review and merge it?

devvsakib
devvsakib approved these changes Oct 28, 2022
View reviewed changes
Copy link
Copy Markdown
Owner

@devvsakib devvsakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,
just dont use var varibale

@devvsakib devvsakib merged commit de6939c into devvsakib:master Oct 28, 2022
@devvsakib
Copy link
Copy Markdown
Owner

devvsakib commented Oct 28, 2022

Oh ohhkk...I didn't know about that as I'm new to it😅. I'm reopening this PR. Can you please review and merge it?

marged and hacktoberfest label added

@Tanyaverma3114
Copy link
Copy Markdown
Contributor Author

Tanyaverma3114 commented Oct 28, 2022

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devvsakib devvsakib devvsakib approved these changes

Assignees

No one assigned

Labels

hacktoberfest hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tanyaverma3114 @devvsakib