docker: Update Dockerfile.cpu to support PETSc docker image #2778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoeLeibowitz
requested review from
EdCaunt,
FabioLuporini,
JDBetteridge and
mloubout
mloubout
approved these changes
Oct 27, 2025
mloubout
reviewed
Oct 27, 2025
| RUN apt-get install -y wget flex libnuma-dev hwloc curl cmake git \ | ||
| autoconf libtool build-essential procps software-properties-common | ||
| autoconf libtool build-essential procps software-properties-common \ | ||
| pkgconf gfortran libopenblas-serial-dev |
Contributor
There was a problem hiding this comment.
Why serial? The generic one enforce parallel?
Contributor
Author
There was a problem hiding this comment.
Not 100% sure on this but I went for the simpler/safer option for now based on various statements made here
Contributor
There was a problem hiding this comment.
Yes, the default (non-serial) will respect $OMP_NUM_THREADS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2778 +/- ##
==========================================
+ Coverage 83.03% 83.05% +0.02%
==========================================
Files 248 248
Lines 50499 50499
Branches 4440 4440
==========================================
+ Hits 41933 41944 +11
+ Misses 7806 7796 -10
+ Partials 760 759 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EdCaunt
approved these changes
Oct 28, 2025
JDBetteridge
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.