Skip to content

Conversation

@mloubout
Copy link
Contributor

This is not the best solution and ideally we would fix the array interface.

Currently, things like a.data[:] *= s with s scalar will create s * a.data` then broadcast it to all ranks (eeech) even with one rank. Temporary patch until we fix it properly.

@mloubout mloubout added the MPI mpi-related label Jul 24, 2025
Copy link
Contributor

@JDBetteridge JDBetteridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nitpicks, if urgent address later

@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.32%. Comparing base (217a3af) to head (03ff042).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
devito/data/data.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2685      +/-   ##
==========================================
- Coverage   92.02%   91.32%   -0.70%     
==========================================
  Files         245      245              
  Lines       49093    49093              
  Branches     4322     4322              
==========================================
- Hits        45176    44835     -341     
- Misses       3216     3538     +322     
- Partials      701      720      +19     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 72.51% <50.00%> (ø)
pytest-gpu-nvc-nvidiaX ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mloubout mloubout merged commit a487058 into main Jul 24, 2025
35 of 36 checks passed
@mloubout mloubout deleted the data-singlempi branch July 24, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MPI mpi-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants