compiler: Add buf-reuse opt-option and rcompile caching #2674
+122
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2674 +/- ##
==========================================
+ Coverage 87.66% 91.34% +3.67%
==========================================
Files 245 245
Lines 49024 49082 +58
Branches 4313 4321 +8
==========================================
+ Hits 42979 44835 +1856
+ Misses 5310 3530 -1780
+ Partials 735 717 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EdCaunt
reviewed
Jul 21, 2025
devito/operator/operator.py
Outdated
| self.exprs = exprs | ||
| self.cls = cls | ||
|
|
||
| # NOTE: Constructed lazyly at `__call__` time because `**kwargs` is |
| assert np.all(u.data == u1.data) | ||
|
|
||
|
|
||
| def test_buffer_reuse(): |
Contributor
There was a problem hiding this comment.
Is it worth also having a test to make sure that non-reusable buffers don't get reused, even when this option is enabled?
Contributor
Author
There was a problem hiding this comment.
most tests already cover that in PRO
FabioLuporini
force-pushed
the
min-buffer-mem
branch
from
432da81 to
7b56b63
Compare
FabioLuporini
force-pushed
the
min-buffer-mem
branch
from
7b56b63 to
4d4758d
Compare
mloubout
approved these changes
Jul 22, 2025
EdCaunt
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.