-
Notifications
You must be signed in to change notification settings - Fork 247
ci: Fix pytest regression #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
==========================================
- Coverage 91.99% 87.59% -4.41%
==========================================
Files 245 245
Lines 48495 48495
Branches 4261 4261
==========================================
- Hits 44612 42477 -2135
- Misses 3202 5297 +2095
- Partials 681 721 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The purpose of this PR is to fix a pytest regression by removing the now-irrelevant ignore flag for PytestReturnNotNoneWarning from the CI configuration.
- Removed the line ignoring PytestReturnNotNoneWarning in pytest.ini to align with pytest 8.4 changes.
EdCaunt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be better to have an if-else structure which checks the PyTest version so it doesn't trip users up if they have a mismatched version
Well checks passing indicates that there aren't any tests returning non- |
|
Need to update the bound on pytest in
Can we be extra safe, enforce |
|
All checks passing with |
There is a regression in pytest 8.4 from the undocumented removal of
PytestReturnNotNoneWarning, which was previously ignored in CI viapytest.ini. This PR just removes the line that ignores that warning.