api: fix kwargs processing for tensor functions #2604
Merged
+57
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devito/types/basic.py
Outdated
| @classmethod | ||
| def _sympify(self, arg): | ||
| # This is used internally by sympy to process arguments at rebuilt. And since | ||
| # some of our property are non-sympyfiable we need to make sure we have a fallback |
devito/types/tensor.py
Outdated
| return orders | ||
| else: | ||
| return orders[0] | ||
| # return ({a.space_order for a in self} - {None}).pop() |
mloubout
force-pushed
the
tens-kwargs
branch
2 times, most recently
from
d8bfd46 to
1dd5f5a
Compare
devito/types/tensor.py
Outdated
| for k, v in kwargs.items(): | ||
| if isinstance(v, MatrixBase): | ||
| sub_kwargs[k] = v[i, j] | ||
| else: |
Contributor
There was a problem hiding this comment.
it's imho one of those cases in which elif isinstance(v, <what's needed here>): .... else: .... would read more smoothly than a nested try-except (but I'm nitpicking here)
devito/types/tensor.py
Outdated
| # Setup kwargs for subfunction | ||
| # Through rebuilding or user input, the kwargs could be | ||
| # Tensors as well from a per-component property | ||
| sub_kwargs = {} |
Contributor
There was a problem hiding this comment.
seems redundant, perhaps factor out in a utility function? or a private method?
mloubout
force-pushed
the
tens-kwargs
branch
3 times, most recently
from
18d1f9b to
0f421b6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
==========================================
- Coverage 91.91% 91.91% -0.01%
==========================================
Files 245 245
Lines 48403 48427 +24
Branches 4252 4255 +3
==========================================
+ Hits 44491 44513 +22
- Misses 3235 3237 +2
Partials 677 677
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FabioLuporini
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of tensor kwargs when they are provided as per-compoenent