mpi: Fix halo exchanges from BundleViews #2602
Merged
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2602 +/- ##
==========================================
- Coverage 91.92% 91.91% -0.01%
==========================================
Files 245 245
Lines 48396 48399 +3
Branches 4251 4252 +1
==========================================
+ Hits 44486 44487 +1
- Misses 3234 3235 +1
- Partials 676 677 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EdCaunt
reviewed
May 9, 2025
| for f in self.target.components: | ||
| # Since the components are by construction homogeneous, any will do | ||
| v = self.target | ||
| if isinstance(v, BundleView): |
Contributor
There was a problem hiding this comment.
Given this is fixing a bug, it might be prudent to include a test
Contributor
Author
There was a problem hiding this comment.
obviously, I'm not that arteriosclerotic yet 😂 as I wrote in the PR description, the test(s) is upcoming in PRO.
EdCaunt
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MFEs in PRO