compiler: Fix bug in concretization of conditionals containing Thicknesses #2510
+40
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2510 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 238 238
Lines 45706 45724 +18
Branches 4057 4058 +1
=======================================
+ Hits 39893 39911 +18
Misses 5128 5128
Partials 685 685 ☔ View full report in Codecov by Sentry. |
mloubout
reviewed
Jan 6, 2025
Contributor
mloubout
left a comment
mloubout
left a comment
There was a problem hiding this comment.
Can you open an issue that subs is broken with your MFE as it might pop up again since this fix the usage not the bug
Except that GTG
mloubout
approved these changes
Jan 6, 2025
georgebisbas
approved these changes
Jan 7, 2025
Contributor
georgebisbas
left a comment
georgebisbas
left a comment
There was a problem hiding this comment.
Seems that CI still breaks for the scipy ascent....otherwise gtg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.