api: more robust processing of custom weight with spacing #2489
+42
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
force-pushed
the
custom-coeff-spacing
branch
4 times, most recently
from
7ca8be2 to
21a0e31
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2489 +/- ##
=======================================
Coverage 87.28% 87.29%
=======================================
Files 238 238
Lines 45347 45366 +19
Branches 4028 4029 +1
=======================================
+ Hits 39583 39602 +19
Misses 5083 5083
Partials 681 681 ☔ View full report in Codecov by Sentry. |
|
|
||
|
|
||
| @check_input | ||
| # @check_input |
devito/finite_differences/tools.py
Outdated
| return len(list(weights)), None | ||
| # Adimensional weight from custom coeffs need to be multiplied by h^order | ||
| if not all(sympify(w).has(dim.spacing) for w in weights if w != 0): | ||
| scale = True |
Contributor
There was a problem hiding this comment.
scale = not all(....)
21a0e31 to
6f00de2
Compare
FabioLuporini
approved these changes
Nov 17, 2024
Contributor
FabioLuporini
left a comment
FabioLuporini
left a comment
There was a problem hiding this comment.
uncontroversial now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.