compiler: Bump default block size #2412
Merged
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgebisbas
approved these changes
Jul 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2412 +/- ##
=======================================
Coverage 86.72% 86.72%
=======================================
Files 235 235
Lines 44698 44701 +3
Branches 8286 8288 +2
=======================================
+ Hits 38766 38769 +3
Misses 5207 5207
Partials 725 725 ☔ View full report in Codecov by Sentry. |
EdCaunt
approved these changes
Jul 17, 2024
mloubout
approved these changes
Jul 17, 2024
| # TODO: move default value to __new__ | ||
| try: | ||
| return {self.step.name: 8} | ||
| return {self.step.name: 16} |
Contributor
There was a problem hiding this comment.
nitpicking: Can we add a "TODO" to check the args for space order and have some empirical 2*space_order or something?
Contributor
Author
There was a problem hiding this comment.
doing in a sec in upcoming PR, merging this one now
FabioLuporini
force-pushed
the
change-default-bs
branch
from
4dbdcd8 to
e8cbefe
Compare
FabioLuporini
force-pushed
the
change-default-bs
branch
from
e8cbefe to
c98988f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's virtually always faster