Skip to content

Conversation

@EdCaunt
Copy link
Contributor

@EdCaunt EdCaunt commented Jul 15, 2024

Separated from #2405, since I think I need to go back to the drawing board on that one, but this patch fixes a bug currently in master.

@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.76%. Comparing base (3024584) to head (d69cc43).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2408      +/-   ##
==========================================
+ Coverage   86.74%   86.76%   +0.02%     
==========================================
  Files         235      235              
  Lines       44550    44563      +13     
  Branches     8250     8250              
==========================================
+ Hits        38644    38665      +21     
+ Misses       5187     5175      -12     
- Partials      719      723       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncontroversial

@FabioLuporini FabioLuporini merged commit 6e79f1c into master Jul 16, 2024
@FabioLuporini FabioLuporini deleted the subdomainset_fix branch July 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants