Test split library side #67
Conversation
mmulholla
force-pushed
the
TestSplitLibrarySide
branch
2 times, most recently
from
7eced8f to
43cabf5
Compare
|
|
||
| validator := DevfileValidator{} | ||
| follower := DevfileFollower{} | ||
| libraryData, err := devfileData.NewDevfileData("2.0.0") |
There was a problem hiding this comment.
In the future, we should probably think about randomizing this as well, so that we test all the versions. And all the schema versions currently available are here
There was a problem hiding this comment.
The tests do not support multiple versions yet, but certainly will be added in the future.
|
Please rebase since #66 is merged to ensure there is no intermittent failure on concurrent threads. |
mmulholla
force-pushed
the
TestSplitLibrarySide
branch
from
9e2b4b4 to
af1d2e2
Compare
Done, ran test a dozen times with now issue. |
|
@maysunfaisal all comments now addressed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, mmulholla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
The library side of the existing tests after moving common code to the api repo. No new tests, just re-org of the code to work with the split. Fully tested, but may occassionaly fail due to a bug in the library code which is fixed in #66